fix: panic on launch from tokio::spawn in window close handler#214
Closed
MeckMan2025 wants to merge 2 commits intojamiepine:mainfrom
Closed
fix: panic on launch from tokio::spawn in window close handler#214MeckMan2025 wants to merge 2 commits intojamiepine:mainfrom
MeckMan2025 wants to merge 2 commits intojamiepine:mainfrom
Conversation
The window close handler in on_window_event used tokio::spawn directly, which panics because there is no Tokio reactor running in that context. Replaced with tauri::async_runtime::spawn which correctly routes through Tauri's managed async runtime. Fixes: "there is no reactor running, must be called from the context of a Tokio 1.x runtime" panic on app launch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved a comment in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiepine
added a commit
that referenced
this pull request
Mar 13, 2026
Cherry-picked and adapted from PR #89 and #214: - Linux audio capture via PulseAudio/PipeWire monitor sources (cpal) - AMD ROCm GPU support: HSA_OVERRIDE_GFX_VERSION env var, ROCm detection - Whisper Turbo model (openai/whisper-large-v3-turbo) in all endpoints - Cleaner Whisper language handling via generate_kwargs - tauri::async_runtime::spawn fix to prevent panic on app shutdown - Enable Linux (ubuntu-22.04) in release CI matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_window_eventclose handler usedtokio::spawndirectly, which panics with "there is no reactor running, must be called from the context of a Tokio 1.x runtime" because the handler runs outside the Tokio runtime context.tauri::async_runtime::spawnwhich correctly routes through Tauri's managed async runtime.Details
One-line change in
tauri/src-tauri/src/main.rsline 678:This crash occurs on every launch — the app compiles and starts, then immediately panics before the window renders.
Test plan
window-close-requestedevent, responds, and window closes)🤖 Generated with Claude Code
Summary by CodeRabbit